Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementations for the time crate #257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jetuk
Copy link

@jetuk jetuk commented Dec 1, 2023

This adds a new feature, time, which enables the time crate. JsonSchema implementations are provided for the time::{OffsetDateTime, PrimitiveDateTime, Date, Time}. The existing time modules are renamed to std_time.

@jnicholls
Copy link

@GREsau Can you please accept this PR? Thanks.

@dspatoulas
Copy link

dspatoulas commented Aug 15, 2024

I'd also love to use this feature, I prefer time over chrono. If it helps increase the priority, there's another PR to add this feature: #207

@rdrpenguin04
Copy link

I'd also like this added. In my current API, I copied this implementation of JsonSchema for PrimitiveDateTime into a helper function so I could use it.

@jetuk
Copy link
Author

jetuk commented Sep 2, 2024

I've rebased this against current master if that helps. However, it looks like there's an issue with MSRV with one of time's dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants